Remove reg_preimage columns in KeccakStark #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@npwardberkeley If you have some time, would you mind taking a look at this and letting me know what you think? |
evm/src/keccak/keccak_stark.rs
Outdated
| @@ -53,7 +63,7 @@ impl<F: RichField + Extendable<D>, const D: usize> KeccakStark<F, D> { | |||
| /// in our lookup arguments, as those are computed after transposing to column-wise form. | |||
| fn generate_trace_rows( | |||
| &self, | |||
| inputs: Vec<[u64; NUM_INPUTS]>, | |||
| inputs: Vec<([u64; NUM_INPUTS], usize)>, | |||
There was a problem hiding this comment.
nit: rename to inputs_and_timestamps?
evm/src/keccak/keccak_stark.rs
Outdated
| Column::single(reg_step(NUM_ROUNDS - 1)) | ||
| } | ||
|
|
||
| pub fn ctl_filter_input<F: Field>() -> Column<F> { |
There was a problem hiding this comment.
nit: for consistency, I think it should be inputs and outputs, and inputs should come first
npwardberkeley
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the 50
reg_preimagecolumns inKeccakStark, at the cost of:KeccakSpongeStark),Keccak's CTLs (so one extra CTL with one lookedKeccaktable and one lookingKeccakSpongetable).